Re: [RFC PATCH v3 06/35] arch/sh/boards/of-generic.c: some cleanup.

On Thu, 19 Oct 2023 03:37:57 +0900,
Geert Uytterhoeven wrote:
> 
> Hi Sato-san,
> 
> On Sat, Oct 14, 2023 at 4:54 PM Yoshinori Sato
> <[email protected]> wrote:
> > Signed-off-by: Yoshinori Sato <[email protected]>
> 
> Thanks for your patch!
> 
> > --- a/arch/sh/boards/of-generic.c
> > +++ b/arch/sh/boards/of-generic.c
> > @@ -140,25 +132,13 @@ static void __init sh_of_init_irq(void)
> >         irqchip_init();
> >  }
> >
> > -static int __init sh_of_clk_init(void)
> > -{
> > -#ifdef CONFIG_COMMON_CLK
> > -       /* Disabled pending move to COMMON_CLK framework. */
> > -       pr_info("SH generic board support: scanning for clk providers\n");
> > -       of_clk_init(NULL);
> > -#endif
> > -       return 0;
> > -}
> > -
> 
> Removing this breaks J2 for sure? I guess this should be merged with
> "[RFC PATCH v3 07/35] arch/sh/kernel/time.c: support COMMON_CLK."
> to avoid a bisection regression?
>

J2 timer (jcore-pit) used TIMER_OF_DECLARE
This is the correct OF implementation, so it is initialized with timer_probe.
I would like to eliminate as many SH-specific methods as possible.

> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> -- 
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds

-- 
Yosinori Sato