Re: [PATCH 16/22] bcachefs: mark bch2_target_to_text_sb() static
Kent Overstreet <[email protected]>
| Newsgroups | gmane.linux.kernel,gmane.linux.kbuild.devel,gmane.linux.ports.alpha,gmane.linux.kernel.arc,gmane.linux.ports.arm.kernel,gmane.linux.ports.mips,gmane.linux.ports.ppc64.devel,gmane.linux.ports.riscv,gmane.linux.ports.sh.devel,gmane.linux.ports.sparc,gmane.linux.network,gmane.linux.ports.parisc,gmane.linux.usb.general,gmane.comp.video.dri.devel,gmane.linux.drivers.mtd |
|---|---|
| Message-ID | <[email protected]> |
On Wed, Nov 08, 2023 at 01:58:37PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann <[email protected]> > > bch2_target_to_text_sb() is only called in the file it is defined in, > and it has no extern prototype: > > fs/bcachefs/disk_groups.c:583:6: error: no previous prototype for 'bch2_target_to_text_sb' [-Werror=missing-prototypes] > > Mark it static to avoid the warning and have the code better optimized. > > Fixes: bf0d9e89de2e ("bcachefs: Split apart bch2_target_to_text(), bch2_target_to_text_sb()") > Signed-off-by: Arnd Bergmann <[email protected]> This is already fixed in my tree.