Re: [PATCH v4 09/37] dt-bindings: timer: renesas,tmu: add renesas,tmu-sh7750

On 15/11/2023 09:17, Geert Uytterhoeven wrote:
> Hi Krzysztof,
> 
> On Tue, Nov 14, 2023 at 10:26 PM Krzysztof Kozlowski <[email protected]> wrote:
>> On 14/11/2023 09:00, Yoshinori Sato wrote:
>>> Add SH7750 TMU entry.
>>>
>>> Signed-off-by: Yoshinori Sato <[email protected]>
> 
>>> diff --git a/Documentation/devicetree/bindings/timer/renesas,tmu.yaml b/Documentation/devicetree/bindings/timer/renesas,tmu.yaml
>>> index a67e427a9e7e..925c2a691b25 100644
>>> --- a/Documentation/devicetree/bindings/timer/renesas,tmu.yaml
>>> +++ b/Documentation/devicetree/bindings/timer/renesas,tmu.yaml
>>> @@ -21,6 +21,7 @@ properties:
>>>    compatible:
>>>      items:
>>>        - enum:
>>> +          - renesas,tmu-sh7750   # SH7750
>>>            - renesas,tmu-r8a7740  # R-Mobile A1
>>>            - renesas,tmu-r8a774a1 # RZ/G2M
>>>            - renesas,tmu-r8a774b1 # RZ/G2N
>>> @@ -46,7 +47,14 @@ properties:
>>>
>>>    interrupts:
>>>      minItems: 2
>>> -    maxItems: 3
>>> +    maxItems: 4
>>> +
>>> +  interrupt-names:
>>> +    items:
>>> +      - const: tuni0
>>> +      - const: tuni1
>>> +      - const: tuni2
>>> +      - const: ticpi2
>>
>> Other variants should be constrained to three items.
> 
> Actually that is not true: the number of interrupts depends on the
> instance, not on the SoC.  The fourth interrupt is present on some
> instances on other SoCs, too, but was never described before, as the
> driver doesn't support it yet (I know this is not a good reason).
> Of course none of this is obvious to the casual reviewer if it is
> not mentioned in the patch description...
> 
> I'm working on making this more clear, and adding support for missing
> variants.

OK, thanks for explanation.

Best regards,
Krzysztof