Re: [PATCH v4 12/37] pci: pci-sh7751: Add SH7751 PCI driver

On Tue, Nov 14, 2023 at 05:00:03PM +0900, Yoshinori Sato wrote:
> Renesas SH7751 CPU Internal PCI Controller driver.

I sent comments on this that seem to have been mostly ignored:

  https://lore.kernel.org/r/20231016172742.GA1215127@bhelgaas

After this series, we have both:

  arch/sh/drivers/pci/pci-sh7751.c
  drivers/pci/controller/pci-sh7751.c

They don't *look* very similar, so maybe we need both.  But I don't
know what the difference is.

Also git am complains when applying this series (also mentioned in the
previous email above):

  Applying: sh: passing FDT address to kernel startup.
  .git/rebase-apply/patch:25: trailing whitespace.

  warning: 1 line adds whitespace errors.
  Applying: irqchip: SH7751 IRL external encoder with enable gate.
  .git/rebase-apply/patch:33: new blank line at EOF.
  +
  warning: 1 line adds whitespace errors.

> Signed-off-by: Yoshinori Sato <[email protected]>
> ---
>  drivers/pci/controller/Kconfig      |   9 +
>  drivers/pci/controller/Makefile     |   1 +
>  drivers/pci/controller/pci-sh7751.c | 293 ++++++++++++++++++++++++++++
>  3 files changed, 303 insertions(+)
>  create mode 100644 drivers/pci/controller/pci-sh7751.c

Bjorn