Re: [DO NOT MERGE v6 23/37] mfd: sm501: Convert platform_data to OF property
Lee Jones <[email protected]>
| Newsgroups | gmane.linux.kernel.clk,gmane.linux.ports.sh.devel,gmane.linux.ide,gmane.linux.drivers.devicetree,gmane.linux.kernel,gmane.linux.kernel.renesas-soc,gmane.comp.video.dri.devel,gmane.linux.kernel.pci,gmane.linux.serial |
|---|---|
| Message-ID | <[email protected]> |
On Tue, 09 Jan 2024, Yoshinori Sato wrote: > Various parameters of SM501 can be set using platform_data, > so parameters cannot be passed in the DeviceTree target. > Expands the parameters set in platform_data so that they can be > specified using DeviceTree properties. > > Signed-off-by: Yoshinori Sato <[email protected]> > --- > drivers/mfd/sm501.c | 436 ++++++++++++++++++++++++++++++++++ How has this grown from 99 lines to 436 lines? Most of it almost certainly needs moving (back?) out to the leaf drivers. A great deal of the properties parsed in here are only relevant to a single device (display for instance). Please move all non-generic handling out to the relevant subsystems. > drivers/video/fbdev/sm501fb.c | 106 +++++++++ > 2 files changed, 542 insertions(+) -- Lee Jones [李琼斯]