Re: [PATCH linux-next v3 10/14] sh, crash: wrap crash dumping code into crash related ifdefs
Baoquan He <[email protected]>
| Newsgroups | gmane.linux.ports.riscv,gmane.linux.kernel,gmane.linux.kernel.kexec,gmane.linux.ports.arm.kernel,gmane.linux.ports.ppc64.devel,gmane.linux.ports.sh.devel,gmane.linux.ports.mips |
|---|---|
| Message-ID | <ZbEg+aoWKPww71gW@MiWiFi-R3L-srv> |
On 01/24/24 at 09:13am, John Paul Adrian Glaubitz wrote: > Hello Baoquan, > > On Wed, 2024-01-24 at 13:12 +0800, Baoquan He wrote: > > Now crash codes under kernel/ folder has been split out from kexec > > code, crash dumping can be separated from kexec reboot in config > > items on SuperH with some adjustments. > > > > wrap up crash dumping codes with CONFIG_CRASH_DUMP ifdeffery, and > > use IS_ENABLED(CONFIG_CRASH_RESERVE) check to decide if compiling > > in the crashkernel reservation code. > > Comparing this to the patches, it seems you missed the first word > "Here". Either amend that or write the word "wrap" capitalized. > > I would omit "Here" as it's not necessary and just start the > sentence with "Wrap". You are right, thanks for careful checking. I will see if I need repost to include this update. > > -- > .''`. John Paul Adrian Glaubitz > : :' : Debian Developer > `. `' Physicist > `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913 > > _______________________________________________ > kexec mailing list > [email protected] > http://lists.infradead.org/mailman/listinfo/kexec >