Re: [RESEND v7 13/37] dt-bindings: clock: sh7750-cpg: Add renesas,sh7750-cpg header.
Geert Uytterhoeven <[email protected]>
| Newsgroups | gmane.linux.kernel.clk,gmane.linux.ports.sh.devel,gmane.linux.ide,gmane.linux.drivers.devicetree,gmane.linux.kernel,gmane.linux.kernel.renesas-soc,gmane.comp.video.dri.devel,gmane.linux.kernel.pci,gmane.linux.serial |
|---|---|
| Message-ID | <CAMuHMdWnioh8er_xDvEY8ny9TgEyfb9AR-p2paS7D4OrbKykvg@mail.gmail.com> |
Hi Sato-san, Thanks for the update! On Thu, Apr 4, 2024 at 7:15 AM Yoshinori Sato <[email protected]> wrote: > > SH7750 CPG Clock output define. (from my comments on v6) Please improve the patch description. > Signed-off-by: Yoshinori Sato <[email protected]> > index 000000000000..04c10b0834ee > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/renesas,sh7750-cpg.yaml The actual bindings LGTM. > +examples: > + - | > + #include <dt-bindings/clock/sh7750-cpg.h> > + cpg: clock-controller@ffc00000 { > + #clock-cells = <1>; > + #power-domain-cells = <0>; > + compatible = "renesas,sh7751r-cpg"; > + clocks = <&extal>; > + clock-names = "extal"; > + reg = <0xffc00000 20>, <0xfe0a0000 16>; > + reg-names = "FRQCR", "CLKSTP00"; > + renesas,mode = <0>; > + }; Please read https://docs.kernel.org/devicetree/bindings/dts-coding-style.html#order-of-properties-in-device-node Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds