Re: [PATCH 1/2] sh: convert the last use of 'optional' property in Kconfig

On Mon, Apr 22, 2024 at 2:51 AM John Paul Adrian Glaubitz
<[email protected]> wrote:
>
> Hi Masahiro,
>
> On Sun, 2024-04-21 at 21:08 +0900, Masahiro Yamada wrote:
> > The 'choice' statement is primarily used to exclusively select one
> > option, but the 'optional' property allows all entries to be disabled.
> >
> > This feature is only used in arch/sh/Kconfig because the equivalent
> > outcome can be achieved by inserting one more entry as a place-holder.
> > This approach is commonly used, for example, LTO_NONE, DEBUG_INFO_NONE,
> > INITRAMFS_COMPRESSION_NONE, etc.
> >
> > The 'optional' property support will be removed from Kconfig.
> >
> > This commit converts the last user.
> >
> > Note:
> >  The 'default CMDLINE_OVERWRITE' statement does not work as intended
> >  in combination with 'optional'. If neither CONFIG_CMDLINE_OVERWRITE
> >  nor CONFIG_CMD_EXTEND is specified in a defconfig file, both of them
> >  are disabled. This is a bug. To maintain the current behavior, I
> >  added CONFIG_CMD_NO_MODIFY=y to those defconfig files.
>          ^^^^^^^^^^^^^^^^^^^^^^
>      This would be CMDLINE_NO_MODIFY as used in the actual Kconfig files.
>
> I am fine with the change per se, but could you rename CMDLINE_NO_MODIFY to
> CMDLINE_FROM_BOOTLOADER as it's used on the other architectures such as arm
> and powerpc, preferably using the same help text.



OK, but the sh behavior is different from
early_init_dt_scan_chosen().


I will drop this part:
"If the boot loader doesn't provide any, the default
kernel command string provided in CMDLINE will be used."




config CMDLINE_FROM_BOOTLOADER
       bool "Use bootloader kernel arguments"
       help
         Uses the command-line options passed by the boot loader.







>
> Also, I usually prefer the first word in the subject to be capitalized, ie..
>
>         sh: Convert the last use of 'optional' property in Kconfig
>
> Thanks,
> Adrian
>
> --
>  .''`.  John Paul Adrian Glaubitz
> : :' :  Debian Developer
> `. `'   Physicist
>   `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913
>


-- 
Best Regards
Masahiro Yamada