Re: [PATCH] sh: j2: drop incorrect SPI controller max frequency property
Krzysztof Kozlowski <[email protected]>
| Newsgroups | gmane.linux.ports.sh.devel,gmane.linux.drivers.devicetree,gmane.linux.kernel |
|---|---|
| Message-ID | <[email protected]> |
On 29/04/2024 10:16, John Paul Adrian Glaubitz wrote: > On Fri, 2024-03-22 at 07:42 +0100, Krzysztof Kozlowski wrote: >> The J2 SPI controller bindings never allowed spi-max-frequency property >> in the controller node. Neither old spi-bus.txt bindings, nor new DT >> schema allows it. Linux driver does not parse that property from >> controller node, thus drop it from DTS as incorrect hardware >> description. The SPI child device has already the same property with >> the same value, so functionality should not be affected. >> >> Cc: Kousik Sanagavarapu <[email protected]> >> Signed-off-by: Krzysztof Kozlowski <[email protected]> >> --- >> arch/sh/boot/dts/j2_mimas_v2.dts | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/arch/sh/boot/dts/j2_mimas_v2.dts b/arch/sh/boot/dts/j2_mimas_v2.dts >> index fa9562f78d53..faf884f53804 100644 >> --- a/arch/sh/boot/dts/j2_mimas_v2.dts >> +++ b/arch/sh/boot/dts/j2_mimas_v2.dts >> @@ -71,8 +71,6 @@ spi0: spi@40 { >> #address-cells = <1>; >> #size-cells = <0>; >> >> - spi-max-frequency = <25000000>; >> - >> reg = <0x40 0x8>; >> >> sdcard@0 { > > It seems that spi-bus.txt has been replaced by spi-controller.yaml now, so > I think we should update the filename in the commit message, shouldn't we? I think commit msg properly says what is old and what is new.... Best regards, Krzysztof