Re: [PATCH 00/20] sh: Fix missing prototypes

Hi Geert,

On Fri, 2024-03-01 at 22:02 +0100, Geert Uytterhoeven wrote:
> 	Hi all,
> 
> This patch series fixes several "no previous prototype for <foo>"
> warnings when building a kernel for SuperH.
> 
> Known issues:
>   - The various warnings about cache functions are not yet fixed, but
>     I didn't want to hold off the rest of this series,
>   - sdk7786_defconfig needs "[PATCH/RFC] locking/spinlocks: Make __raw_*
>     lock ops static" [1],
>   - Probably there are more warnings to fix, I didn't build all
>     defconfigs.
> 
> This has been boot-tested on landisk and on qemu/rts7751r2d.
> 
> Thanks for your comments!
> 
> [1] https://lore.kernel.org/linux-sh/c395b02613572131568bc1fd1bc456d20d1a5426.1709325647.git.geert+renesas@glider.be
> 
> Geert Uytterhoeven (20):
>   sh: pgtable: Fix missing prototypes
>   sh: fpu: Add missing forward declarations
>   sh: syscall: Add missing forward declaration for sys_cacheflush()
>   sh: tlb: Add missing forward declaration for handle_tlbmiss()
>   sh: return_address: Add missing #include <asm/ftrace.h>
>   sh: traps: Add missing #include <asm/setup.h>
>   sh: hw_breakpoint: Add missing forward declaration for
>     arch_bp_generic_fields()
>   sh: boot: Add proper forward declarations
>   sh: ftrace: Fix missing prototypes
>   sh: nommu: Add missing #include <asm/cacheflush.h>
>   sh: math-emu: Add missing #include <asm/fpu.h>
>   sh: dma: Remove unused dmac_search_free_channel()
>   sh: sh2a: Add missing #include <asm/processor.h>
>   sh: sh7786: Remove unused sh7786_usb_use_exclock()
>   sh: smp: Fix missing prototypes
>   sh: kprobes: Merge arch_copy_kprobe() into arch_prepare_kprobe()
>   sh: kprobes: Make trampoline_probe_handler() static
>   sh: kprobes: Remove unneeded kprobe_opcode_t casts
>   sh: dwarf: Make dwarf_lookup_fde() static
>   [RFC] sh: dma: Remove unused functionality
> 
>  arch/sh/boot/compressed/cache.c         |   3 +
>  arch/sh/boot/compressed/cache.h         |  10 ++
>  arch/sh/boot/compressed/misc.c          |   8 +-
>  arch/sh/boot/compressed/misc.h          |   9 ++
>  arch/sh/drivers/dma/dma-api.c           | 143 ------------------------
>  arch/sh/include/asm/dma.h               |   7 --
>  arch/sh/include/asm/fpu.h               |   3 +
>  arch/sh/include/asm/ftrace.h            |  10 ++
>  arch/sh/include/asm/hw_breakpoint.h     |   2 +
>  arch/sh/include/asm/syscalls.h          |   1 +
>  arch/sh/include/asm/tlb.h               |   4 +
>  arch/sh/kernel/cpu/sh2a/opcode_helper.c |   2 +
>  arch/sh/kernel/cpu/sh4a/setup-sh7786.c  |  14 ---
>  arch/sh/kernel/dwarf.c                  |   2 +-
>  arch/sh/kernel/kprobes.c                |  13 +--
>  arch/sh/kernel/return_address.c         |   2 +
>  arch/sh/kernel/smp.c                    |   4 +-
>  arch/sh/kernel/traps.c                  |  10 +-
>  arch/sh/kernel/traps_32.c               |   1 +
>  arch/sh/math-emu/math.c                 |   2 +
>  arch/sh/mm/nommu.c                      |   2 +
>  arch/sh/mm/pgtable.c                    |   4 +-
>  arch/sh/mm/tlbex_32.c                   |   1 +
>  23 files changed, 68 insertions(+), 189 deletions(-)
>  create mode 100644 arch/sh/boot/compressed/cache.h
>  create mode 100644 arch/sh/boot/compressed/misc.h
> 

For the whole series:

Reviewed-by: John Paul Adrian Glaubitz <[email protected]>

I would still like to get feedback from Yoshinori on patch #20 though, i.e.

	"sh: dma: Remove unused functionality".

On the other hand, we could just merge this series and re-add the functions
later if we decide they're still needed.

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913