Re: [PATCH 09/15] sh: rework sync_file_range ABI
"Arnd Bergmann" <[email protected]>
| Newsgroups | gmane.linux.ports.hexagon,gmane.linux.kernel.cross-arch,gmane.linux.kernel,gmane.linux.ports.sparc,gmane.linux.ports.sh.devel,gmane.linux.lib.musl.general,gmane.linux.ltp,gmane.comp.lib.glibc.alpha,gmane.linux.ports.parisc,gmane.linux.ports.mips,gmane.linux.kernel.stable,gmane.linux.file-systems,gmane.linux.ports.ppc64.devel |
|---|---|
| Message-ID | <[email protected]> |
On Mon, Jun 24, 2024, at 08:14, John Paul Adrian Glaubitz wrote:
> On Fri, 2024-06-21 at 11:41 +0200, Arnd Bergmann wrote:
>> On Fri, Jun 21, 2024, at 10:44, John Paul Adrian Glaubitz wrote:
>> > Did you also check what order libc uses? I would expect libc on SuperH
>> > misordering the
>> > arguments as well unless I am missing something. Or do we know that the
>> > code is actually
>> > currently broken?
>>
>> Yes, I checked glibc, musl and uclibc-ng for all the cases in
>> which the ABI made no sense, as well as to check that my analysis
>> of the kernel sources matches the expectations of the libc.
>
> OK, awesome.
>
> Will you send a v2 so I can ack the updated version of the patch?
>
> I'm also fine with the patch going through your tree, as I would
> like to start with the changes for v6.11 this week.
I should be able to get a v2 out today and apply that to my
asm-generic tree to have in linux-next before I send the
pull request.
Arnd