Re: [PATCH] sh: push-switch: add missing MODULE_DESCRIPTION() macro

John Paul Adrian Glaubitz <[email protected]>
Newsgroups gmane.linux.ports.sh.devel,gmane.linux.kernel,gmane.linux.kernel.janitors
Message-ID <5473f57a21639724e6277c3e271fc46ea5f62ed3.camel@physik.fu-berlin.de>
Hi Jeff,

On Tue, 2024-07-02 at 12:29 -0700, Jeff Johnson wrote:
> With ARCH=sh, make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in arch/sh/drivers/push-switch.o
> 
> Add the missing invocation of the MODULE_DESCRIPTION() macro.
> 
> Signed-off-by: Jeff Johnson <[email protected]>
> ---
> MODULE_DESCRIPTION copied from file prologue:
> /*
>  * Generic push-switch framework
>  *
>  * Copyright (C) 2006  Paul Mundt
>  */
> ---
>  arch/sh/drivers/push-switch.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/sh/drivers/push-switch.c b/arch/sh/drivers/push-switch.c
> index 362e4860bf52..1dea43381b5a 100644
> --- a/arch/sh/drivers/push-switch.c
> +++ b/arch/sh/drivers/push-switch.c
> @@ -131,4 +131,5 @@ module_exit(switch_exit);
>  
>  MODULE_VERSION(DRV_VERSION);
>  MODULE_AUTHOR("Paul Mundt");
> +MODULE_DESCRIPTION("Generic push-switch framework");
>  MODULE_LICENSE("GPL v2");
> 
> ---
> base-commit: 1dfe225e9af5bd3399a1dbc6a4df6a6041ff9c23
> change-id: 20240702-md-sh-arch-sh-drivers-40af731eb66c

Reviewed-by: John Paul Adrian Glaubitz <[email protected]>

Thanks for fixing this. Will pick this up later this week.

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.