Re: [PATCH 11/17] x86/numa: numa_{add,remove}_cpu: make cpu parameter unsigned
Jonathan Cameron <[email protected]>
| Newsgroups | gmane.linux.kernel.cross-arch,gmane.linux.kernel,gmane.linux.ports.arm.kernel,gmane.linux.ports.mips,gmane.linux.ports.ppc64.devel,gmane.linux.ports.riscv,gmane.linux.ports.sh.devel,gmane.linux.ports.sparc,gmane.linux.acpi.devel,gmane.linux.drivers.devicetree,gmane.linux.kernel.mm |
|---|---|
| Organization | Huawei Technologies Research and Development (UK) Ltd. |
| Message-ID | <[email protected]> |
On Tue, 16 Jul 2024 14:13:40 +0300 Mike Rapoport <[email protected]> wrote: > From: "Mike Rapoport (Microsoft)" <[email protected]> > > CPU id cannot be negative. > > Making it unsigned also aligns with declarations in > include/asm-generic/numa.h used by arm64 and riscv and allows sharing > numa emulation code with these architectures. > > Signed-off-by: Mike Rapoport (Microsoft) <[email protected]> Makes sense for both reasons. FWIW given how simple it is. Maybe worth bringing a few more functions inline with this? Probably something for another day given we don't care about the inconsistency for this series. Reviewed-by: Jonathan Cameron <[email protected]>