Re: [PATCH v3 23/26] of, numa: return -EINVAL when no numa-node-id is found
David Hildenbrand <[email protected]>
| Newsgroups | gmane.linux.documentation,gmane.linux.kernel,gmane.linux.drivers.devicetree,gmane.linux.acpi.devel,gmane.linux.kernel.cross-arch,gmane.linux.ports.arm.kernel,gmane.linux.ports.mips,gmane.linux.kernel.mm,gmane.linux.ports.riscv,gmane.linux.ports.sh.devel,gmane.linux.ports.ppc64.devel,gmane.linux.ports.sparc |
|---|---|
| Organization | Red Hat |
| Message-ID | <[email protected]> |
On 01.08.24 08:08, Mike Rapoport wrote: > From: "Mike Rapoport (Microsoft)" <[email protected]> > > Currently of_numa_parse_memory_nodes() returns 0 if no "memory" node in > device tree contains "numa-node-id" property. This makes of_numa_init() > to return "success" despite no NUMA nodes were actually parsed and set > up. > > arch_numa workarounds this by returning an error if numa_nodes_parsed is > empty. > > numa_memblks however would WARN() in such case and since it will be used > by arch_numa shortly, such warning is not desirable. > > Make sure of_numa_init() returns -EINVAL when no NUMA node information > was found in the device tree. > > Signed-off-by: Mike Rapoport (Microsoft) <[email protected]> > --- Acked-by: David Hildenbrand <[email protected]> -- Cheers, David / dhildenb