Re: [PATCH v8 14/14] sound: Make CONFIG_SND depend on INDIRECT_IOMEM instead of UML
Takashi Iwai <[email protected]>
| Newsgroups | gmane.linux.ports.ppc.embedded,gmane.linux.ports.arm.kernel,gmane.linux.kernel,gmane.linux.ports.alpha,gmane.linux.ports.parisc,gmane.linux.ports.sh.devel,gmane.linux.uml.devel,gmane.linux.kernel.cross-arch,gmane.linux.ports.arm.msm,gmane.linux.drivers.mtd,gmane.linux.sound |
|---|---|
| Message-ID | <[email protected]> |
On Tue, 08 Oct 2024 09:50:22 +0200, Julian Vetter wrote: > > When building for the UM arch and neither INDIRECT_IOMEM=y, nor > HAS_IOMEM=y is selected, the build fails because the memcpy_fromio and > memcpy_toio functions are not defined. Fix it here by depending on > HAS_IOMEM or INDIRECT_IOMEM. > > Reviewed-by: Yann Sionneau <[email protected]> > Signed-off-by: Julian Vetter <[email protected]> > --- > Changes for v8: > - New patch > --- > sound/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/Kconfig b/sound/Kconfig > index 4c036a9a420a..8b40205394fe 100644 > --- a/sound/Kconfig > +++ b/sound/Kconfig > @@ -1,7 +1,7 @@ > # SPDX-License-Identifier: GPL-2.0-only > menuconfig SOUND > tristate "Sound card support" > - depends on HAS_IOMEM || UML > + depends on HAS_IOMEM || INDIRECT_IOMEM > help > If you have a sound card in your computer, i.e. if it can say more > than an occasional beep, say Y. Acked-by: Takashi Iwai <[email protected]> thanks, Takashi