Re: [PATCH v5 4/8] module: prepare to handle ROX allocations for text
Song Liu <[email protected]>
| Newsgroups | gmane.linux.ports.alpha,gmane.linux.kernel.bpf,gmane.linux.kernel.cross-arch,gmane.linux.ports.arm.kernel,gmane.linux.ports.hexagon,gmane.linux.kernel,gmane.linux.ports.mips,gmane.linux.kernel.mm,gmane.linux.kernel.modules,gmane.linux.ports.parisc,gmane.linux.ports.riscv,gmane.linux.ports.sh.devel,gmane.linux.kernel.arc,gmane.linux.uml.devel,gmane.linux.ports.ppc64.devel,gmane.linux.ports.sparc |
|---|---|
| Message-ID | <CAPhsuW6gb76T_75TPzb-AvfyAcYE83iYhDpjJNHJQWDd3Fki_Q@mail.gmail.com> |
On Wed, Oct 9, 2024 at 10:47 PM Mike Rapoport <[email protected]> wrote: > > On Wed, Oct 09, 2024 at 03:23:40PM -0700, Song Liu wrote: > > On Wed, Oct 9, 2024 at 11:10 AM Mike Rapoport <[email protected]> wrote: > > [...] > > > diff --git a/include/linux/module.h b/include/linux/module.h > > > index 88ecc5e9f523..7039f609c6ef 100644 > > > --- a/include/linux/module.h > > > +++ b/include/linux/module.h > > > @@ -367,6 +367,8 @@ enum mod_mem_type { > > > > > > struct module_memory { > > > void *base; > > > + void *rw_copy; > > > + bool is_rox; > > > unsigned int size; > > > > Do we really need to hold the rw_copy all the time? > > We hold it only during module initialization, it's freed in > post_relocation. Ah, I missed this part. Sorry for the noise. Song