Re: [PATCH mm-unstable v2 00/16] mm: Introduce arch_mmap_hint()
Matthew Wilcox <[email protected]>
| Newsgroups | gmane.linux.ports.alpha,gmane.linux.kernel,gmane.linux.kernel.arc,gmane.linux.ports.arm.kernel,gmane.linux.ports.mips,gmane.linux.ports.parisc,gmane.linux.ports.ppc64.devel,gmane.linux.ports.sh.devel,gmane.linux.ports.sparc,gmane.linux.kernel.mm |
|---|---|
| Message-ID | <[email protected]> |
On Wed, Dec 11, 2024 at 03:27:38PM -0800, Kalesh Singh wrote:
> Hi all,
>
> This is v2 othe the arch_mmap_hint() series.
>
> Changes in v2:
> - MAP_FIXED case is also handled in arch_mmap_hint() since this is just a
> special case of the hint addr being "enforced", per Yang Shi.
> - Consolidate most of the error handling in arch_mmap_hint().
> - Patch 16 ("mm: Fallback to generic_mmap_hint()") was folded into
> Patch 2 ("mm: x86: Introduce arch_mmap_hint()")
>
> v1: https://lore.kernel.org/r/[email protected]/
>
> =======
>
> This series introduces arch_mmap_hint() to handle allocating VA space
> for the hint address.
But why? You're basically forcing me to read the entire series to
figure out what you're doing and why. I decline.
> Patches 1-16 introduce this new helper and Patch 17 uses it to fix the
> issue of mmap hint being ignored in some cases due to THP alignment [1]
>
> [1] https://lore.kernel.org/r/[email protected]/
>
> Thanks,
> Kalesh
>
>
> Kalesh Singh (16):
> mm: Introduce generic_mmap_hint()
> mm: x86: Introduce arch_mmap_hint()
> mm: arm: Introduce arch_mmap_hint()
> mm: alpha: Introduce arch_mmap_hint()
> mm: arc: Use generic_mmap_hint()
> mm: csky: Introduce arch_mmap_hint()
> mm: loongarch: Introduce arch_mmap_hint()
> mm: mips: Introduce arch_align_mmap_hint()
> mm: parisc: Introduce arch_align_mmap_hint()
> mm: s390: Use generic_mmap_hint()
> mm: sh: Introduce arch_mmap_hint()
> mm: sparc32: Introduce arch_mmap_hint()
> mm: sparc64: Introduce arch_mmap_hint()
> mm: xtensa: Introduce arch_mmap_hint()
> mm: powerpc: Introduce arch_mmap_hint()
> mm: Respect mmap hint before THP alignment if allocation is possible
>
> arch/alpha/include/asm/pgtable.h | 1 +
> arch/alpha/kernel/osf_sys.c | 31 +++---
> arch/arc/include/asm/pgtable.h | 1 +
> arch/arc/mm/mmap.c | 43 +++++----
> arch/arm/include/asm/pgtable.h | 1 +
> arch/arm/mm/mmap.c | 107 +++++++++------------
> arch/csky/abiv1/inc/abi/pgtable-bits.h | 1 +
> arch/csky/abiv1/mmap.c | 68 +++++++------
> arch/loongarch/include/asm/pgtable.h | 1 +
> arch/loongarch/mm/mmap.c | 49 +++++-----
> arch/mips/include/asm/pgtable.h | 1 +
> arch/mips/mm/mmap.c | 50 +++++-----
> arch/parisc/include/asm/pgtable.h | 1 +
> arch/parisc/kernel/sys_parisc.c | 53 +++++-----
> arch/powerpc/include/asm/book3s/64/slice.h | 1 +
> arch/powerpc/mm/book3s64/slice.c | 31 ++++++
> arch/s390/include/asm/pgtable.h | 1 +
> arch/s390/mm/mmap.c | 51 +++++-----
> arch/sh/include/asm/pgtable.h | 1 +
> arch/sh/mm/mmap.c | 83 ++++++----------
> arch/sparc/include/asm/pgtable_32.h | 1 +
> arch/sparc/include/asm/pgtable_64.h | 1 +
> arch/sparc/kernel/sys_sparc_32.c | 33 ++++---
> arch/sparc/kernel/sys_sparc_64.c | 96 +++++++-----------
> arch/x86/include/asm/pgtable_64.h | 1 +
> arch/x86/kernel/sys_x86_64.c | 64 ++++++------
> arch/xtensa/kernel/syscall.c | 31 ++++--
> include/linux/sched/mm.h | 9 ++
> mm/huge_memory.c | 17 ++--
> mm/mmap.c | 86 +++++++++++------
> 30 files changed, 491 insertions(+), 424 deletions(-)
>
> --
> 2.47.0.338.g60cca15819-goog
>
>