Re: [PATCH v4 04/15] mm: pgtable: add statistics for P4D level page table
Qi Zheng <[email protected]>
| Newsgroups | gmane.linux.ports.sparc,gmane.linux.kernel.mm,gmane.linux.ports.arm.kernel,gmane.linux.ports.ppc64.devel,gmane.linux.ports.riscv,gmane.linux.kernel,gmane.linux.kernel.cross-arch,gmane.linux.ports.hexagon,gmane.linux.ports.mips,gmane.linux.ports.sh.devel,gmane.linux.uml.devel |
|---|---|
| Message-ID | <[email protected]> |
On 2025/1/3 00:53, Kevin Brodsky wrote:
> On 30/12/2024 10:07, Qi Zheng wrote:
>> diff --git a/arch/riscv/include/asm/pgalloc.h b/arch/riscv/include/asm/pgalloc.h
>> index 551d614d3369c..3466fbe2e508d 100644
>> --- a/arch/riscv/include/asm/pgalloc.h
>> +++ b/arch/riscv/include/asm/pgalloc.h
>> @@ -108,8 +108,12 @@ static inline void __pud_free_tlb(struct mmu_gather *tlb, pud_t *pud,
>> static inline void __p4d_free_tlb(struct mmu_gather *tlb, p4d_t *p4d,
>> unsigned long addr)
>> {
>> - if (pgtable_l5_enabled)
>> + if (pgtable_l5_enabled) {
>> + struct ptdesc *ptdesc = virt_to_ptdesc(p4d);
>> +
>> + pagetable_p4d_dtor(ptdesc);
>> riscv_tlb_remove_ptdesc(tlb, virt_to_ptdesc(p4d));
>
> Nit: could use the new ptdesc variable here instead of calling
> virt_to_ptdesc().
Right, but we will remove pagetable_p4d_dtor() in patch #10, so this
may not matter.
Thanks!
>
> - Kevin