Re: Re: [PATCH v4 -next 13/15] x86: vdso: move the sysctl to arch/x86/entry/vdso/vdso32-setup.c

On Mon, Dec 30, 2024 at 02:43:12PM +0800, yukaixiong wrote:
> 
> 
> On 2024/12/30 7:05, Brian Gerst wrote:
> > On Sat, Dec 28, 2024 at 10:17 AM Kaixiong Yu <[email protected]> wrote:
...
> >>          return 0;
> >>   }
> >>   __initcall(ia32_binfmt_init);
> >>   #endif /* CONFIG_SYSCTL */
> >>
> >> -#endif /* CONFIG_X86_64 */
> >
> > Brian Gerst
> > .
> Hello all；
> 
> I want to confirm that I should send a new patch series, such as "PATCH 
> v5 -next"， or just modify this patch by
> "git send-email -in-reply-to xxxxx"，or the maintainer will fix this issue ?
There are still some outstanding comments (besides this one) to the
series that you must address. This is what I propose:

1. Address the outstanding feedback in the series
2. Wait a couple of more days to see if you get more feedback
3. For your next versions, please include the tags from previous
   reviews; I see that you have not added Lorenzo's reviewed by for
   "[PATCH v4 -next 06/15] mm: mmap: move sysctl to mm/mmap.c" and
   "[PATCH v4 -next 08/15] mm: nommu: move sysctl to mm/nommu.c"
4. Once you have addresses all the issues, Send a V5. If there are still
   issues with this version, then we can cherry-pick the patches that
   are already reviewed into upstream and continue working on the ones
   with issues.

Best

-- 

Joel Granados