Re: [PATCH v4 12/15] s390: pgtable: also move pagetable_dtor() of PxD to __tlb_remove_table()
Qi Zheng <[email protected]>
| Newsgroups | gmane.linux.ports.ppc.embedded,gmane.linux.kernel.mm,gmane.linux.ports.arm.kernel,gmane.linux.ports.riscv,gmane.linux.ports.sparc,gmane.linux.kernel,gmane.linux.kernel.cross-arch,gmane.linux.ports.hexagon,gmane.linux.ports.mips,gmane.linux.ports.sh.devel,gmane.linux.uml.devel |
|---|---|
| Message-ID | <[email protected]> |
On 2025/1/6 22:35, Alexander Gordeev wrote: > On Mon, Jan 06, 2025 at 09:34:55PM +0800, Qi Zheng wrote: >> OK, will change the subject and description to: >> >> s390: pgtable: also move pagetable_dtor() of PxD to pagetable_dtor_free() >> >> To unify the PxD and PTE TLB free path, also move the pagetable_dtor() of >> PMD|PUD|P4D to pagetable_dtor_free(). >> >> But pagetable_dtor_free() is newly introduced in this patch, should it >> be changed to 'move ... to pagetable_pte_dtor_free()'? But this seems >> strange. :( > > s390: pgtable: consolidate PxD and PTE TLB free paths > > Call pagetable_dtor() for PMD|PUD|P4D tables just before ptdesc is > freed - same as it is done for PTE tables. That allows consolidating > TLB free paths for all table types. > > Makes sense? Ah, make sense. Many thanks to you! Will do it in v5. > >> Thanks! > > Thank you!