Re: [PATCH v4 13/15] mm: pgtable: introduce generic __tlb_remove_table()
Andreas Larsson <[email protected]>
| Newsgroups | gmane.linux.ports.riscv,gmane.linux.kernel.mm,gmane.linux.ports.arm.kernel,gmane.linux.ports.ppc64.devel,gmane.linux.ports.sparc,gmane.linux.kernel,gmane.linux.kernel.cross-arch,gmane.linux.ports.hexagon,gmane.linux.ports.mips,gmane.linux.ports.sh.devel,gmane.linux.uml.devel |
|---|---|
| Message-ID | <[email protected]> |
On 2024-12-30 10:07, Qi Zheng wrote: > diff --git a/arch/sparc/include/asm/tlb_32.h b/arch/sparc/include/asm/tlb_32.h > index 5cd28a8793e39..910254867dfbd 100644 > --- a/arch/sparc/include/asm/tlb_32.h > +++ b/arch/sparc/include/asm/tlb_32.h > @@ -2,6 +2,7 @@ > #ifndef _SPARC_TLB_H > #define _SPARC_TLB_H > > +#define __HAVE_ARCH_TLB_REMOVE_TABLE sparc32 does not select MMU_GATHER_TABLE_FREE, and therefore does not have (nor need) __tlb_remove_table, so this define should not be added. > #include <asm-generic/tlb.h> > > #endif /* _SPARC_TLB_H */ > diff --git a/arch/sparc/include/asm/tlb_64.h b/arch/sparc/include/asm/tlb_64.h > index 3037187482db7..1a6e694418e39 100644 > --- a/arch/sparc/include/asm/tlb_64.h > +++ b/arch/sparc/include/asm/tlb_64.h > @@ -33,6 +33,7 @@ void flush_tlb_pending(void); > #define tlb_needs_table_invalidate() (false) > #endif > > +#define __HAVE_ARCH_TLB_REMOVE_TABLE > #include <asm-generic/tlb.h> > > #endif /* _SPARC64_TLB_H */ LGTM. With the removal of the define for sparc32 in v5: Acked-by: Andreas Larsson <[email protected]> # sparc Thanks, Andreas