Re: [PATCH v5 09/17] arm64: pgtable: move pagetable_dtor() to __tlb_remove_table()
Will Deacon <[email protected]>
| Newsgroups | gmane.linux.ports.ppc.embedded,gmane.linux.kernel.mm,gmane.linux.ports.arm.kernel,gmane.linux.ports.riscv,gmane.linux.ports.sparc,gmane.linux.kernel,gmane.linux.kernel.cross-arch,gmane.linux.ports.hexagon,gmane.linux.ports.mips,gmane.linux.ports.sh.devel,gmane.linux.uml.devel |
|---|---|
| Message-ID | <20250113162931.GB14101@willie-the-truck> |
On Wed, Jan 08, 2025 at 02:57:25PM +0800, Qi Zheng wrote: > Move pagetable_dtor() to __tlb_remove_table(), so that ptlock and page > table pages can be freed together (regardless of whether RCU is used). > This prevents the use-after-free problem where the ptlock is freed > immediately but the page table pages is freed later via RCU. > > Page tables shouldn't have swap cache, so use pagetable_free() instead of > free_page_and_swap_cache() to free page table pages. > > Signed-off-by: Qi Zheng <[email protected]> > Suggested-by: Peter Zijlstra (Intel) <[email protected]> > Reviewed-by: Kevin Brodsky <[email protected]> > Cc: [email protected] > --- > arch/arm64/include/asm/tlb.h | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) Acked-by: Will Deacon <[email protected]> Will