Re: [PATCH 4/5] x86: pgtable: unconditionally use tlb_remove_table()
Peter Zijlstra <[email protected]>
| Newsgroups | gmane.linux.uml.devel,gmane.linux.kernel.mm,gmane.linux.kernel,gmane.linux.ports.hexagon,gmane.linux.ports.mips,gmane.linux.ports.sh.devel,gmane.linux.ports.riscv |
|---|---|
| Message-ID | <[email protected]> |
On Fri, Jan 24, 2025 at 09:00:58PM +0800, Qi Zheng wrote: > > > On 2025/1/24 19:38, Peter Zijlstra wrote: > > On Thu, Jan 23, 2025 at 09:26:17PM +0800, Qi Zheng wrote: > > > If the CONFIG_MMU_GATHER_TABLE_FREE is disabled, the tlb_remove_table() > > > will fall back to pagetable_dtor() + tlb_remove_page(). So let's use > > > tlb_remove_table() unconditionally to free page table pages. > > > > > > Signed-off-by: Qi Zheng <[email protected]> > > > Suggested-by: Peter Zijlstra (Intel) <[email protected]> > > > > I think we can clean up more :-) > > Yes, but Rik van Riel has already done the same thing in his patch series > [1], so I was originally planning to wait for his patch to be > merged into the linux-next branch, and then rebase this series onto his > patch. Duh, yeah, I've actually seen those patches and totally forgot he did that... -ETOOMUCHEMAIL :/