Re: [PATCH v3 2/6] syscall.h: add syscall_set_arguments() and syscall_set_return_value()
"Dmitry V. Levin" <[email protected]>
| Newsgroups | gmane.linux.ports.hexagon,gmane.linux.kernel.arc,gmane.linux.ports.mips,gmane.linux.ports.sparc,gmane.linux.ports.sh.devel,gmane.comp.sysutils.strace.devel,gmane.linux.kernel.cross-arch,gmane.linux.uml.devel,gmane.linux.ports.arm.kernel,gmane.linux.ports.parisc,gmane.linux.ports.ppc64.devel,gmane.linux.kernel,gmane.linux.ports.riscv |
|---|---|
| Message-ID | <[email protected]> |
On Tue, Jan 28, 2025 at 04:04:34PM +0100, Christophe Leroy wrote: > Le 28/01/2025 à 10:16, Dmitry V. Levin a écrit : > > These functions are going to be needed on all HAVE_ARCH_TRACEHOOK > > architectures to implement PTRACE_SET_SYSCALL_INFO API. > > The subject is misleading. syscall_set_return_value() already exists on > most architectures and was not addressed by commit 7962c2eddbfe. > > Maybe it would be better to handle syscall_set_return_value() in a > separate commit. syscall_set_return_value() is being added only on hexagon. I didn't think it worth a separate commit, but it's certainly possible to split this commit into two. -- ldv