Re: [PATCH 2/2] irqchip: clocksource: fix jcore-pit irq request
Geert Uytterhoeven <[email protected]>
| Newsgroups | gmane.linux.kernel,gmane.linux.ports.sh.devel |
|---|---|
| Message-ID | <CAMuHMdWX9xeLRDLnteGWR31KbhtdupxVbhjQqY-6VaFA4tVaBQ@mail.gmail.com> |
Hi Daniel, On Wed, 19 Feb 2025 at 15:43, Daniel Lezcano <[email protected]> wrote: > On 16/02/2025 18:55, Artur Rojek wrote: > > The jcore-aic irqchip does not have separate interrupt numbers reserved > > for cpu-local vs global interrupts. Instead, the task of selecting this > > property is being delegated to the device drivers requesting the given > > irq. > > > > This quirk has not been taken into account while migrating jcore-pit to > > request_percpu_irq(), resulting in a failure to register PIT interrupts. > > > > Fix this behavior by making the following changes: > > 1) Explicitly register irq_set_percpu_devid() in jcore-pit. > > 2) Provide enable_percpu_irq()/disable_percpu_irq() calls in jcore-pit. > > 3) Make jcore-aic pass the correct per-cpu cookie to the irq handler by > > using handle_percpu_devid_irq() instead of handle_percpu_irq(). > > > > Fixes: 69a9dcbd2d65 ("clocksource/drivers/jcore: Use request_percpu_irq()") > > > > Signed-off-by: Artur Rojek <[email protected]> > > --- > > How this patch should be merged ? > > It is touching irqchip and clocksource at the same time. > > May I pick it in the clocksource tree ? Thomas already took it, cfr. commit d7e3fd658248f257 ("irqchip/jcore-aic, clocksource/drivers/jcore: Fix jcore-pit interrupt request") in next-20250219. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds