Re: [PATCH v4 08/13] serial: sh-sci: Introduced function pointers

Hi Paul,

> We discussed both approaches internally and did an initial
> proof-of-concept of a separate driver. The result was over 1,000 lines
> of code copy-pasted from the existing sh-sci driver into the new driver,
> which is generally something maintainers want us to avoid doing.

Darn, 1000 lines of logic is a lot...

> trade off here is whether we want a single more complex driver, or two
> copies of much of the code so that bugfixes/improvements to the common
> sections in the future need to be duplicated.

Exactly.

> The RZ/V2H and RZ/G3E have interfaces of both the existing sh-sci
> register layout ("SCIF" ports in RZ/V2H & RZ/G3E manual) and the RZ/T2H
> style register layout ("RSCI" ports in RZ/V2H manual, "SCI" ports in
> RZ/G3E manual), so keeping things closely aligned as we move forward
> will be beneficial. I expect that this will be easier with a combined
> driver.

I will have a look at the series.

Happy hacking,

   Wolfram

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmfZ6V0ACgkQFA3kzBSg
Kba5ahAAl/Ml/ppwI24PMjK1c4ePEYFQ5vJsj56tZw+c4I6ys1LCKjEuwYVYXYTe
6Wg8A6/IxSYrxhrqqTECYBwcnryDDUNXJ5vKRdhqVPRCYVbgHIhqblKA4LVUTAzi
9+e2Ip1hRNdZP+H/fSSN9zF2EDfQQng8J2pCIdcBkBzzTh/cYfCgdkpJnIMpKIe4
SiEQKiOuVs1epIHFPpqO4vw46tw5SCgJCxtZetaqx5ZJRjn/d7YbCs7J5MDxAX8j
bEloxNKmjLVdt5MCKhHXdhxmzwrf7lY6api2Le3unyiDFSA3PEzZnoVRThvY4Jux
2UqwkjAiA7+LoIi+Mwan0b9v2hgby7QhuF47ZcHn+gIC4fVER+0Pxt69kxM0yt9U
qjgjZNfG7v7MJZRAgePdxW8kzPU5ZWj8ympsxe6r5scPIMvujtM6tTCCYT62AXhX
S3RnbP0+vVVh4xMUOvXP9ShX56H4b/JB92l51uc0xpPQVm287dT+5gexuu9j03vg
dIyMaJnomQ2AJvMH3c32u10H5JtdXzl7Z5i9dCS6fFh03QkJjS3krHRXbk7pJqMT
nV95tj3IBOmeDtP7Nb+dJ4Ni9Y9vK8hMpCSFkF8FFJnGcrUv3JF9ejcZ2aIu1pzy
mr1dTJR2VZMrj6kbACexmh7lnrt8ZOO85OYCDt5iy0QcmMI9lIE=
=yaiH
-----END PGP SIGNATURE-----