Re: [PATCH v2 09/13] arch, mm: set max_mapnr when allocating memory map for FLATMEM
Christophe Leroy <[email protected]>
| Newsgroups | gmane.linux.uml.devel,gmane.linux.ports.alpha,gmane.linux.kernel,gmane.linux.kernel.arc,gmane.linux.ports.arm.kernel,gmane.linux.ports.hexagon,gmane.linux.ports.mips,gmane.linux.ports.parisc,gmane.linux.ports.ppc64.devel,gmane.linux.ports.riscv,gmane.linux.ports.sh.devel,gmane.linux.ports.sparc,gmane.linux.kernel.cross-arch,gmane.linux.kernel.mm |
|---|---|
| Message-ID | <[email protected]> |
Hi Mike, Le 14/03/2025 à 10:25, Christophe Leroy a écrit : > > > Le 13/03/2025 à 14:49, Mike Rapoport a écrit : >> From: "Mike Rapoport (Microsoft)" <[email protected]> >> >> max_mapnr is essentially the size of the memory map for systems that use >> FLATMEM. There is no reason to calculate it in each and every >> architecture >> when it's anyway calculated in alloc_node_mem_map(). >> >> Drop setting of max_mapnr from architecture code and set it once in >> alloc_node_mem_map(). > > As far as I can see alloc_node_mem_map() is called quite late. > > I fear that it will regress commit daa9ada2093e ("powerpc/mm: Fix boot > crash with FLATMEM") > > Can you check ? I see this patch is now merged into mainline (v6.15-rc1). Have you been able to check and/or analyse whether it doesn't regress the fix in commit daa9ada2093e ("powerpc/mm: Fix boot crash with FLATMEM") ? Thanks Christophe