Re: [PATCH 1/2] dmaengine: sh: Do not enable SH_DMAE_BASE by default during compile testing

CC linux-sh

Hi Krzysztof,

On Fri, 4 Apr 2025 at 14:22, Krzysztof Kozlowski
<[email protected]> wrote:
> Enabling the compile test should not cause automatic enabling of all
> drivers.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>

Thanks for your patch, which is now commit 587dd30449fb1012
("dmaengine: sh: Do not enable SH_DMAE_BASE by default during
compile testing") in dmaengine/next.

> --- a/drivers/dma/sh/Kconfig
> +++ b/drivers/dma/sh/Kconfig
> @@ -16,7 +16,7 @@ config SH_DMAE_BASE
>         depends on SUPERH || COMPILE_TEST
>         depends on !SUPERH || SH_DMA
>         depends on !SH_DMA_API
> -       default y
> +       default SUPERH || SH_DMA

I think the check for SUPERH is superfluous, due to the dependency on
"!SUPERH || SH_DMA" above.

>         select RENESAS_DMA
>         help
>           Enable support for the Renesas SuperH DMA controllers.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds