Re: [PATCH net-next 2/3] sh_eth: Convert to DEFINE_SIMPLE_DEV_PM_OPS()

On 2025-09-05 13:57:05 +0200, Andrew Lunn wrote:
> > You cannot enter system sleep without CONFIG_PM_SLEEP, so enabling
> > WoL would be pointless.
> 
> Yet get_wol will return WoL can be used, and set_wol will allow you to
> configure it. It seems like EOPNOTSUPP would be better.

Out of curiosity. Are you suggesting a compile time check/construct for 
CONFIG_PM_SLEEP be added in the driver itself, or in ethtool_set_wol() 
and ethtool_get_wol() in net/ethtool/ioctl.c to complement the 

    if (!dev->ethtool_ops->get_wol || !dev->ethtool_ops->set_wol)
        return -EOPNOTSUPP;

checks already there? To always return EOPNOTSUPP if PM_SLEEP is not 
selected?

> 
> 	  Andrew

-- 
Kind Regards,
Niklas Söderlund