Re: [PATCH] sh: mach-rsk: rsk7203: use static device properties for LEDs and GPIO buttons
John Paul Adrian Glaubitz <[email protected]>
| Newsgroups | gmane.linux.ports.sh.devel,gmane.linux.kernel |
|---|---|
| Message-ID | <bccfde5bca138b8f3489f517ea62168ec4658336.camel@physik.fu-berlin.de> |
Hi Dmitry, On Mon, 2025-09-08 at 05:27 -0700, Dmitry Torokhov wrote: > On Wed, Aug 13, 2025 at 03:50:09PM +0300, Andy Shevchenko wrote: > > On Mon, Aug 11, 2025 at 03:44:57PM -0700, Dmitry Torokhov wrote: > > > Convert the board to use static device properties instead of platform > > > data to describe LEDs and GPIO-connected buttons on the board, so > > > that support for platform data can be removed from gpio-keys and other > > > drivers, unifying their behavior. > > > > ... > > > > > --- a/arch/sh/boards/mach-rsk/devices-rsk7203.c > > > +++ b/arch/sh/boards/mach-rsk/devices-rsk7203.c > > > > > #include <linux/gpio.h> > > > > Do we still need this one? > > Yes, at least this one still uses gpio_request() for configuring some > GPIOs, so we need to keep it at least for now. > > > > > Ditto for the rest similar cases. > > I'll review them to make sure they are still needed. OK, I'll look forward to your second version of the patch. I might pick it up for v6.18 provided that we'll manage to squeeze it in in time. Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer `. `' Physicist `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913