Re: [PATCH] fbdev/pvr2fb: Fix leftover reference to ONCHIP_NR_DMA_CHANNELS
John Paul Adrian Glaubitz <[email protected]>
| Newsgroups | gmane.linux.ports.sh.devel,gmane.linux.kernel,gmane.comp.video.dri.devel |
|---|---|
| Message-ID | <cee852ea863613abb7b3fe2a2ec3870abecb8b6c.camel@physik.fu-berlin.de> |
Hi Florian,
On Sun, 2025-10-26 at 00:38 +0200, Florian Fuchs wrote:
> Commit e24cca19babe ("sh: Kill off MAX_DMA_ADDRESS leftovers.") removed
> the define ONCHIP_NR_DMA_CHANNELS. So that the leftover reference needs
> to be replaced by CONFIG_NR_ONCHIP_DMA_CHANNELS to compile successfully
> with CONFIG_PVR2_DMA enabled.
>
> Signed-off-by: Florian Fuchs <[email protected]>
> ---
> Note: The fix has been compiled, and tested on real Dreamcast hardware,
> with CONFIG_PVR2_DMA=y.
>
> drivers/video/fbdev/pvr2fb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/pvr2fb.c b/drivers/video/fbdev/pvr2fb.c
> index cbdb1caf61bd..0b8d23c12b77 100644
> --- a/drivers/video/fbdev/pvr2fb.c
> +++ b/drivers/video/fbdev/pvr2fb.c
> @@ -192,7 +192,7 @@ static unsigned long pvr2fb_map;
>
> #ifdef CONFIG_PVR2_DMA
> static unsigned int shdma = PVR2_CASCADE_CHAN;
> -static unsigned int pvr2dma = ONCHIP_NR_DMA_CHANNELS;
> +static unsigned int pvr2dma = CONFIG_NR_ONCHIP_DMA_CHANNELS;
> #endif
>
> static struct fb_videomode pvr2_modedb[] = {
>
> base-commit: 3a8660878839faadb4f1a6dd72c3179c1df56787
Good catch, thanks for fixing this!
Reviewed-by: John Paul Adrian Glaubitz <[email protected]>
Adrian
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer
`. `' Physicist
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913