Re: [PATCH] sh: dma-sysfs: add missing put_device() in dma_create_sysfs_files()
John Paul Adrian Glaubitz <[email protected]>
| Newsgroups | gmane.linux.kernel.stable,gmane.linux.ports.sh.devel,gmane.linux.kernel |
|---|---|
| Message-ID | <8e412a9834ced553c4eb757362a122d26f16213f.camel@physik.fu-berlin.de> |
Hi Markus, On Sat, 2025-12-20 at 14:56 +0100, Markus Elfring wrote: > > If device_register() fails, call put_device() to drop the device > > reference. Also, call device_unregister() if device_create_file() > > fails. > > See also once more: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.19-rc1#n659 > > > You propose to complete the exception handling for two cases. > Is there a need to indicate such a detail in the summary phrase accordingly? Maybe I'm completely missing something here, but I find the description short and reasonable. As the SH maintainer, I haven't started reviewing these patches themselves yet, I definitely interested to understand what the problem is. Thanks, Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer `. `' Physicist `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913