Re: [PATCH v2 2/4] mm: rename my_zero_pfn() to zero_pfn()
"Christophe Leroy (CS GROUP)" <[email protected]>
| Newsgroups | gmane.linux.ports.ppc.embedded,gmane.linux.ports.alpha,gmane.linux.kernel,gmane.linux.kernel.arc,gmane.linux.ports.arm.kernel,gmane.linux.ports.hexagon,gmane.linux.ports.parisc,gmane.linux.ports.riscv,gmane.linux.ports.sh.devel,gmane.linux.ports.sparc,gmane.linux.uml.devel,gmane.linux.kernel.mm |
|---|---|
| Message-ID | <[email protected]> |
Le 09/02/2026 à 15:40, Mike Rapoport a écrit : > From: "Mike Rapoport (Microsoft)" <[email protected]> > > my_zero_pfn() is a silly name. > > Rename zero_pfn variable to zero_page_pfn and my_zero_pfn() function to > zero_pfn(). > > While on it, move extern declarations of zero_page_pfn outside the > functions that use it and add a comment about what ZERO_PAGE is. I guess the idea of the extern declaration being inside its only external users was to ensure nobody would start using it directly, hence bypassing the overloadable helpers. Should we at least call the variable __zero_page_pfn instead in order to warn people that using it directly requires care ? Christophe