Re: [PATCH 57/61] reset: Prefer IS_ERR_OR_NULL over manual NULL check

Philipp Zabel <[email protected]> Tue, 10 Mar 2026 13:43:30 +0100

Newsgroups	gmane.linux.ports.sh.devel
Message-ID	<ddaacda48df23fb2c009a8727518300ed2b82cb2.camel__9830.37291314162$1773151408$gmane$org@pengutronix.de>

Hi Philipp,

On Di, 2026-03-10 at 12:49 +0100, Philipp Hahn wrote:
> Prefer using IS_ERR_OR_NULL() over using IS_ERR() and a manual NULL
> check.
>
> Semantich change: Previously the code only printed the warning on error,
> but not when the pointer was NULL. Now the warning is printed in both
> cases!

No, rstc == NULL is valid (for optional reset controls) and must not
throw a warning.


regards
Philipp