Re: [PATCH 1/9] scripts: kconfig: merge_config.sh: use POSIX '=' in test
Mikko Rapeli <[email protected]>
| Newsgroups | gmane.linux.ports.riscv,gmane.linux.kbuild.devel,gmane.linux.kernel,gmane.linux.ports.alpha,gmane.linux.ports.arm.kernel,gmane.linux.ports.arm.omap,gmane.linux.ports.mips,gmane.linux.ports.ppc64.devel,gmane.linux.ports.sh.devel,gmane.linux.kernel.samsung-soc,gmane.linux.kernel.renesas-soc,gmane.linux.ports.parisc,gmane.comp.hardware.openbmc |
|---|---|
| Message-ID | <abkfJsyQSbW-VjxD@nuoska> |
Hi,
On Tue, Mar 17, 2026 at 10:13:37AM +0100, Vincent Mailhol (Arm) wrote:
> merge_config.sh yields this warning:
>
> ./scripts/kconfig/merge_config.sh: 384: [: false: unexpected operator
>
> This happens because the script runs under /bin/sh but compares
> strings using the '==' operator, which is a bash extension. The POSIX
> test command only specifies '=' for string equality.
>
> Replace '==' with the POSIX-compatible '=' so the script works when
> run with /bin/sh as intended.
>
> Fixes: dfc97e1c5da5 ("scripts: kconfig: merge_config.sh: use awk in checks too")
> Signed-off-by: Vincent Mailhol (Arm) <[email protected]>
This fix is already merged in kbuild trees:
https://lore.kernel.org/linux-kbuild/[email protected]/
https://git.kernel.org/pub/scm/linux/kernel/git/kbuild/linux.git/log/?h=kbuild-fixes-for-next
Cheers,
-Mikko
> ---
> scripts/kconfig/merge_config.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/kconfig/merge_config.sh b/scripts/kconfig/merge_config.sh
> index 735e1de450c6..073c6bec5245 100755
> --- a/scripts/kconfig/merge_config.sh
> +++ b/scripts/kconfig/merge_config.sh
> @@ -381,7 +381,7 @@ END {
> STRICT_MODE_VIOLATED=true
> fi
>
> -if [ "$STRICT" == "true" ] && [ "$STRICT_MODE_VIOLATED" == "true" ]; then
> +if [ "$STRICT" = "true" ] && [ "$STRICT_MODE_VIOLATED" = "true" ]; then
> echo "Requested and effective config differ"
> exit 1
> fi
>
> --
> 2.43.0
>