Re: [PATCH 1/9] scripts: kconfig: merge_config.sh: use POSIX '=' in test
"Vincent Mailhol (Arm)" <[email protected]>
| Newsgroups | gmane.linux.ports.riscv,gmane.linux.kbuild.devel,gmane.linux.kernel,gmane.linux.ports.alpha,gmane.linux.ports.arm.kernel,gmane.linux.ports.arm.omap,gmane.linux.ports.mips,gmane.linux.ports.ppc64.devel,gmane.linux.ports.sh.devel,gmane.linux.kernel.samsung-soc,gmane.linux.kernel.renesas-soc,gmane.linux.ports.parisc,gmane.comp.hardware.openbmc |
|---|---|
| Message-ID | <[email protected]> |
On 3/17/26 10:30, Mikko Rapeli wrote:
> Hi,
>
> On Tue, Mar 17, 2026 at 10:13:37AM +0100, Vincent Mailhol (Arm) wrote:
>> merge_config.sh yields this warning:
>>
>> ./scripts/kconfig/merge_config.sh: 384: [: false: unexpected operator
>>
>> This happens because the script runs under /bin/sh but compares
>> strings using the '==' operator, which is a bash extension. The POSIX
>> test command only specifies '=' for string equality.
>>
>> Replace '==' with the POSIX-compatible '=' so the script works when
>> run with /bin/sh as intended.
>>
>> Fixes: dfc97e1c5da5 ("scripts: kconfig: merge_config.sh: use awk in checks too")
>> Signed-off-by: Vincent Mailhol (Arm) <[email protected]>
>
> This fix is already merged in kbuild trees:
>
> https://lore.kernel.org/linux-kbuild/[email protected]/
> https://git.kernel.org/pub/scm/linux/kernel/git/kbuild/linux.git/log/?h=kbuild-fixes-for-next
Noted! I actually started to write this before the other solution was
posted, but, anyway, this will be removed in v2.
Yours sincerely,
Vincent Mailhol