Re: [PATCH] sh: fix fallout from ZERO_PAGE consolidation

John Paul Adrian Glaubitz <[email protected]>
Newsgroups gmane.linux.kernel,gmane.linux.ports.sh.devel
Message-ID <9c6727df3a4b68690c31710a108ad6675f371d38.camel@physik.fu-berlin.de>
Hi,

On Tue, 2026-04-28 at 14:18 +0200, Geert Uytterhoeven wrote:
> Hi Mike,
> 
> On Fri, 17 Apr 2026 at 21:16, Mike Rapoport <[email protected]> wrote:
> > From: "Mike Rapoport (Microsoft)" <[email protected]>
> > 
> > Consolidation of empty_zero_page declarations broke boot on sh.
> > 
> > sh stores its initial boot parameters in a page reserved in
> > arch/sh/kernel/head_32.S. Before commit 6215d9f4470f ("arch, mm:
> > consolidate empty_zero_page") this page was referenced in C code as an
> > array and after that commit it is referenced as a pointer.
> > 
> > This causes wrong code generation and boot hang.
> > 
> > Declare boot_params_page as an array to fix the issue.
> > 
> > Reported-by: Thomas Weißschuh <[email protected]>
> > Tested-by: Thomas Weißschuh <[email protected]>
> > Fixes: 6215d9f4470f ("arch, mm: consolidate empty_zero_page")
> > Signed-off-by: Mike Rapoport (Microsoft) <[email protected]>
> 
> Thanks, this fixes booting on Landisk and QEMU rts7751r2d.
> 
> Tested-by: Geert Uytterhoeven <[email protected]>

I'm going to pick this up later this week. I just wanted to give it a spin myself.

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.