Re: [PATCH v2] sh: maple: fix empty port handling

On 2026-04-26 23:27, Florian Fuchs wrote:
> Fix the handling of empty ports, to restore the ability to use the 
> device
> with less than 4 populated ports and also be able to hot-plug new 
> devices
> in empty ports at runtime.
> 
> Explicitly cast the response code in maple_response_devinfo() to s8 so
> that 0xFF from the device gets interpreted as signed and flows like the
> NONE response, previously it was considered unknown response code, 
> which
> blocked the maple bus.
> 
> Remove the locking variable from maple_vblank_handler() as there is no
> locking information returned from maple_add_packet() and it lead to 
> only
> ever check exactly one empty port.
> 
> Update maple_response_devinfo() to explicitly check for empty ports on
> unit 0, to be able to hot-plug devices in empty ports.
> 
> Signed-off-by: Florian Fuchs <[email protected]>

Hey Florian,

Commit message could be "massaged" a bit, but otherwise everything works
fine. Thanks for fixing this!

Verified on real hardware.

Tested-by: Artur Rojek <[email protected]>
Acked-by: Artur Rojek <[email protected]>