Re: [PATCH tty v4 3/6] serial: sh-sci: Avoid deprecated UPF_CONS_FLOW

On Wed, May 06, 2026 at 02:59:02PM +0206, John Ogness wrote:
> Hi Geert,
> 
> On 2026-05-06, Geert Uytterhoeven <[email protected]> wrote:
> >> --- a/drivers/tty/serial/sh-sci.c
> >> +++ b/drivers/tty/serial/sh-sci.c
> >> @@ -3369,9 +3369,12 @@ static int sci_init_single(struct platform_device *dev,
> >>         }
> >>
> >>         port->type              = SCI_PUBLIC_PORT_ID(p->type);
> >> -       port->flags             = UPF_FIXED_PORT | UPF_BOOT_AUTOCONF | p->flags;
> >> +       port->flags             = UPF_FIXED_PORT | UPF_BOOT_AUTOCONF |
> >> +                                 (p->flags & ~UPF_CONS_FLOW);
> >
> > This seems over-cautious to me.
> > The last setter of p->flags was removed in commit 37744feebc086908
> > ("sh: remove sh5 support") in v5.8.  No platform data ever set the
> > UPF_CONS_FLOW flag before.  I would rather remove plat_sci_port.flags
> > and this "| p->flags", so we don't have to care about UPF_CONS_FLOW
> > in this driver at all.
> 
> If there is a v5, I will drop this patch. If v4 is acceptable, the
> maintainer can just drop this patch.
> 
> I will leave the plat_sci_port.flags removal as an excercise for the sh
> folks.

Ah, this is what confused me.  I've taken the first two patches here,
can you respin the rest on my branch and resend them?

thanks,

greg k-h