[linux-sh:03327] Re: new board for 2.6.8.1

On Wed, Sep 29, 2004 at 04:04:44PM +0900, [email protected] wrote:
> We ported CVS HEAD to our CTP/PCI-SH03 hardware. Can we
> contribute it to LinuxSH, if it's ok?
> 
Mostly this looks ok. there are a few minor issues that need addressing.

> 	* arch/sh/boards/sh03/led.c: New file.

For starters, the led.c code should be made conditional on CONFIG_HEARTBEAT in
arch/sh/boards/sh03/Makefile. This then allows for CONFIG_HEARTBEAT to be
removed from the led.c code. Additionally, mach_led() can go away entirely,
since nothing is actually using it.

> 	* arch/sh/boards/sh03/pci.c: New file.

This should be moved to arch/sh/drivers/pci/ops-sh03.c, with the proper entry
added to arch/sh/drivers/pci/Makefile.

> 	* arch/sh/drivers/pci/pci-sh7751.c: Add CTP/PCI-SH03 support.

This irq routing should likewise be done in arch/sh/drivers/pci/ops-sh03.c,
implemented as pcibios_map_platform_irq(). See the RTS7751R2D code for an
example of how to do this.

Also, please add your board to arch/sh/tools/mach-types.

Beyond those issues, this looks fine.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (GNU/Linux)

iD8DBQFBWoVMvfgmmv+NIDsRAjwYAKCi3+gATwtZ9cqZ4PKIiL7NFKpQTQCgrMtf
jCQtwCWDmpI5IqPDyRH/ydo=
=jIQU
-----END PGP SIGNATURE-----