Re: [discuss] Re: [PATCH] Add key management syscalls to non-i386 archs

Andi Kleen <[email protected]> Thu, 21 Oct 2004 00:56:25 +0200
Newsgroups gmane.linux.ports.mips.general,gmane.linux.kernel,gmane.linux.ports.sparc,gmane.linux.ports.sh.general,gmane.linux.ports.arm.kernel,gmane.linux.ports.ia64,gmane.linux.s390
Message-ID <[email protected]>
On Wed, Oct 20, 2004 at 03:01:49PM -0700, David S. Miller wrote:
> 
> David, I applaud your effort to take care of this.
> However, this patch will conflict with what I've
> sent into Linus already for Sparc.  I also had to
> add the sys_altroot syscall entry as well.
> 
> I've mentioned several times that perhaps the best
> way to deal with this problem is to purposefully
> break the build of platforms when new system calls
> are added.
> 
> Simply adding a:
> 
> #error new syscall entries for X and Y needed
> 
> to include/asm-*/unistd.h would handle this just
> fine I think.

I don't think that's a good idea.  Normally new system calls 
are relatively obscure and the system works fine without them,
so urgent action is not needed.

And I think we can trust architecture maintainers to regularly
sync the system calls with i386.

-Andi