Re: [PATCH 5/8] mm/bootmem_info: stop marking the pgdat as NODE_INFO
"David Hildenbrand (Arm)" <[email protected]>
| Newsgroups | gmane.linux.ports.ppc.embedded,gmane.linux.ports.sparc,gmane.linux.kernel,gmane.linux.kernel.mm |
|---|---|
| Message-ID | <[email protected]> |
On 5/12/26 09:45, Michal Hocko wrote:
> On Mon 11-05-26 16:05:33, David Hildenbrand wrote:
>> We removed the last user of NODE_INFO in commit 119c31caa59e ("mm/sparse:
>> remove !CONFIG_SPARSEMEM_VMEMMAP leftovers for CONFIG_MEMORY_HOTPLUG").
>>
>> But it really was never used it besides for safety-checks ever since it was
>> introduced in commit 04753278769f ("memory hotplug: register section/node
>> id to free"), where we had the comment:
>>
>> 5) The node information like pgdat has similar issues. But, this
>> will be able to be solved too by this.
>> (Not implemented yet, but, remembering node id in the pages.)
>>
>> Of course, that never happened, and we are not planning on freeing the
>> node data (pgdat/pglist_data), during memory hotunplug.
>>
>> So let's just stop marking the pgdat as NODE_INFO.
>
> With the last user, shouldn't we simply drop NODE_INFO?
I'll drop the whole thing in part 2.
I actually had both parts together until I stumbled into the vmmemmap x86
freeing issue that now causes conflicts until upstream and synced to the MM tree.
--
Cheers,
David