Re: kernel-2.6 cvs patches

On Mon, Jun 21, 2004 at 11:23:43PM +0300, Taily wrote:
>
> Today an update was released, and i still got this:
> 
>  CC      drivers/i2c/busses/i2c-xbox.o
> drivers/i2c/busses/i2c-xbox.c:141: error: `I2C_CLASSES_HWMON' undeclared 
> here (not in a function)
> drivers/i2c/busses/i2c-xbox.c:141: error: initializer element is not 
> constant
> drivers/i2c/busses/i2c-xbox.c:141: error: (near initialization for 
> `xbox_adapter.class')
> make[3]: *** [drivers/i2c/busses/i2c-xbox.o] Error 1
> make[2]: *** [drivers/i2c/busses] Error 2
> make[1]: *** [drivers/i2c] Error 2
> make: *** [drivers] Error 2
> 
> I changed I2C_CLASSES_HWMON to I2C_CLASS_HWMON (which was spcified in 
> include/linux/i2c.h)
> 
> After this when it comes to compile vmlinux or something i get lots of 
> these kinds of errors
> 
> drivers/built-in.o(.text+0x4d8b8): In function `riva_load_video_mode':
> : undefined reference to `__floatsidf'
> drivers/built-in.o(.text+0x53f49): In function `fabs':
> : undefined reference to `__gtdf2'
> drivers/built-in.o(.text+0x54257): In function `conexant_calc_mode':
> : undefined reference to `__floatsidf'
> drivers/built-in.o(.text+0x5480e): In function `conexant_calc_mode_params':
> : undefined reference to `__floatsidf'
>
> etc, etc.. Here are only a few errors..
> all errors can be found here
> http://koti.mbnet.fi/taily/errors
> 
> (My compiler is gcc-3.3.3-r6)
> 
This had to bite sooner or later [1].

drivers/video/xbox/{conexant,focus}.c make heavy use of floating-point
arithmetic, which, in-kernel, is a Bad Idea (tm). I don't know how much
accuracy is lost by switching to fixed-point arithmetic, perhaps Oliver
can answer that. In any case, this needs to be fixed [2].

Standard CFLAGS for i386 is "-pipe -msoft-float". A quick work-around
would be to revert ChangeSet 1.1634 in [1] below. Ick.

	Arthur


[1] http://linux.bkbits.net:8080/linux-2.5/[email protected]
[2] http://www.uwsg.iu.edu/hypermail/linux/kernel/0401.0/1789.html
[3] http://www.uwsg.iu.edu/hypermail/linux/kernel/0310.1/1178.html


-------------------------------------------------------
This SF.Net email sponsored by Black Hat Briefings & Training.
Attend Black Hat Briefings & Training, Las Vegas July 24-29 - 
digital self defense, top technical experts, no vendor pitches, 
unmatched networking opportunities. Visit www.blackhat.com