Re: [PATCH net-next v9 06/11] net: ipv6: Use link netns in newlink() of rtnl_link_ops
Xiao Liang <[email protected]>
| Newsgroups | gmane.linux.network.bridge,gmane.org.freifunk.batman,gmane.linux.kernel.bpf,gmane.linux.can,gmane.linux.kernel,gmane.linux.ppp,gmane.linux.drivers.rdma,gmane.linux.kernel.wireless.general,gmane.linux.network,gmane.network.wireguard |
|---|---|
| Message-ID | <CABAhCOT8sCV4RgBWwfYjCw2xoZbdiYG8yuWReigx-u5DibTaiA@mail.gmail.com> |
On Thu, Feb 13, 2025 at 3:05 PM Kuniyuki Iwashima <[email protected]> wrote: > [...] > > diff --git a/net/ipv6/ip6_gre.c b/net/ipv6/ip6_gre.c > > index 863852abe8ea..108600dc716f 100644 > > --- a/net/ipv6/ip6_gre.c > > +++ b/net/ipv6/ip6_gre.c > > @@ -1498,7 +1498,8 @@ static int ip6gre_tunnel_init_common(struct net_device *dev) > > tunnel = netdev_priv(dev); > > > > tunnel->dev = dev; > > - tunnel->net = dev_net(dev); > > + if (!tunnel->net) > > + tunnel->net = dev_net(dev); > > Same question as patch 5 for here and other parts. > Do we need this check and assignment ? > > ip6gre_newlink_common > -> nt->net = dev_net(dev) > -> register_netdevice > -> ndo_init / ip6gre_tunnel_init() > -> ip6gre_tunnel_init_common > -> tunnel->net = dev_net(dev) Will remove this line.