Re: [PATCH net-next v1 1/1] ppp: Fix KMSAN warning by initializing 2-byte header

Jakub Kicinski <[email protected]>
Newsgroups gmane.linux.ppp,gmane.linux.kernel.bpf,gmane.linux.network,gmane.linux.kernel
Message-ID <[email protected]> 
On Tue, 18 Feb 2025 21:31:44 +0800 Jiayuan Chen wrote:
> -		*(u8 *)skb_push(skb, 2) = 1;
> +		*(u16 *)skb_push(skb, 2) = 1;

This will write the 1 to a different byte now, on big endian machines.
Probably doesn't matter but I doubt it's intentional?
-- 
pw-bot: cr
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.