Re: [PATCH net-next v3 0/1] ppp: Replace per-CPU recursion counter with lock-owner field

Paolo Abeni <[email protected]> Thu, 17 Jul 2025 15:40:10 +0200
Newsgroups gmane.linux.ppp,gmane.linux.network
Message-ID <[email protected]>
On 7/15/25 5:08 PM, Sebastian Andrzej Siewior wrote:
> This is another approach to avoid relying on local_bh_disable() for
> locking of per-CPU in ppp.
> 
> I redid it with the per-CPU lock and local_lock_nested_bh() as discussed
> in v1. The xmit_recursion counter has been removed since it served the
> same purpose as the owner field. Both were updated and checked.
> 
> The xmit_recursion looks like a counter in ppp_channel_push() but at
> this point, the counter should always be 0 so it always serves as a
> boolean. Therefore I removed it.
> 
> I do admit that this looks easier to review.

Thanks for reworking the change. I do agree with the above ;)

FTR no need to add a cover letter to a single patch series.

(but, since the matter at hand is IMHO non trivial, in this specific
case I'll preserve the cover letter)

/P