Re: [PATCH net-next v9 1/2] net: pppoe: implement GRO/GSO support

Qingfang Deng <[email protected]> Wed, 13 May 2026 09:26:39 +0800

Newsgroups	gmane.linux.kernel,gmane.linux.network,gmane.linux.ppp
Message-ID	<[email protected]>

On Tue, 12 May 2026 at 19:32:45 +0200, Pablo Neira Ayuso wrote:
> diff --git a/net/netfilter/nf_flow_table_ip.c b/net/netfilter/nf_flow_table_ip.c
> index 9c05a50d6013..270c3d0233ad 100644
> --- a/net/netfilter/nf_flow_table_ip.c
> +++ b/net/netfilter/nf_flow_table_ip.c
> @@ -577,6 +577,10 @@ static int nf_flow_pppoe_push(struct sk_buff *skb, u16 id,
>  		return -1;
>  	}
>  
> +	skb_set_inner_transport_header(skb, skb_transport_offset(skb));
> +	skb_set_inner_protocol(skb, skb->protocol);
> +	skb->encapsulation = 1;
> +

Is this change needed? The PPPoE driver does not touch these fields.

>  	__skb_push(skb, PPPOE_SES_HLEN);
>  	skb_reset_network_header(skb);
>  

Thanks for your tests. 

Regards,
Qingfang