Re: [PATCH net] ppp: annotate lockless queue empty check
Breno Leitao <[email protected]>
| Newsgroups | gmane.linux.ppp,gmane.linux.network,gmane.linux.kernel |
|---|---|
| Message-ID | <[email protected]> |
On Tue, Aug 11, 2026 at 02:02:29PM +0800, Qingfang Deng wrote:
> ppp_poll() checks whether pf->rq contains a packet without holding the
> queue lock. skb_peek() requires appropriate locking or a private queue,
> neither of which applies because ppp_input() can enqueue concurrently.
>
> Only queue emptiness is needed, so use skb_queue_empty_lockless()
> instead.
>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Signed-off-by: Qingfang Deng <[email protected]>
Reviewed-by: Breno Leitao <[email protected].