Re: keep on patchin'

On 8/17/20 7:52 AM, Craig Small wrote:
> ...
> I also had to disable slabinfo checks because it depends on the 
> permissions of /proc/slabinfo (0400 here)

Hi Craig,

That was a big Oops on my part.

In my local test program all those info pointers were global but when I 
made them function-local in the new test program I forgot to initialize 
them to NULL.

Sure wish I had suffered an abend on my platform to tip me off.  Or 
maybe I should have read the procps(3) Caveats section.  Anyway, thanks 
for the catch.

However, your commit goes way too far in extending these tests to 
include successful 'new' and 'unref' calls rather than simply 
**surviving** the totally independent enum/table validations.

In the final analysis it doesn't matter who issues an EXIT_FAILURE -- 
the run_tests guy or an early Exit() out of a procps_new() function. 
They both will produce the desired "FAIL" test diagnostic.

Anyway, here is a fix for your fix that once again allows for including 
the slabtop test.

Regards,

Jim

p.s. Do you think it will be possible to extend 'make check' to include 
this new test?