Re: keep on patchin'

On 9/24/20 7:25 AM, Craig Small wrote:
> For your library check, would the following change do what you need?
> 
> + check-lib: clean
> +       $(MAKE) CFLAGS=-DITEMTABLE_DEBUG
> +       $(top_builddir)/proc/test_Itemtables
> +
> 
> If you do make check-lib it cleans everything runs make again with the 
> flag and then your test program. I'm actually thinking you could cut 
> down what was being made here too as you only need the library and the 
> single test program.

Hi Craig,

Yes, that seems to accomplish the goal, providing one remembers to 
perform this extra step.  But is there a way to clean the library after 
the test so that it's rebuilt without ITEMTABLE_DEBUG should another 
make be issued?

And I agree it would be better if just the library was rebuilt with this 
new target.  It would be even better if no library test programs were 
built until needed (check or check-lib).

> Not sure why you need the -i switch, I don't get this exp error you are 
> talking about. What's it giving you without -i ?

Here are the errors I experience without the '-i' switch.  These fatal 
errors both occur in the 'testsuite' directory.

     make[3]: *** [Makefile:524: check-DEJAGNU] Error 1
     make[2]: *** [Makefile:599: check-am] Error 2

When I use the '-i' switch I get the library test results (colorized 
when not redirected).  But I never get a summary for the user program 
tests like I do when I 'runtest' directly in the testsuite directory.

Lastly, all of the user program tests suffer this warning:

     WARNING: Couldn't find tool init file

Regards,

Jim